Labels support for 0.4.19, points support for > 0.4.19 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass locally. |
melonora
reviewed
May 7, 2024
melonora
reviewed
May 7, 2024
src/napari_spatialdata/_viewer.py
Outdated
| @@ -539,12 +548,13 @@ def add_sdata_points(self, sdata: SpatialData, key: str, selected_cs: str, multi | |||
| np.fliplr(xy) | |||
| # radii_size = _calc_default_radii(self.viewer, sdata, selected_cs) | |||
| radii_size = 3 | |||
| version = get_napari_version() | |||
| kwargs = {"edge_width": 0.0} if version <= packaging.version.parse("0.4.19") else {"border_width": 0.0} | |||
There was a problem hiding this comment.
I would say this solution is very temporary. 0.4.19 had some fixes with layer.events.data that will be important for the table widget so we would need to have 0.4.19 as constraint.
melonora
approved these changes
May 7, 2024
There was a problem hiding this comment.
Pre-emptive approval. I will check regarding the leaking problem. Might have to close the viewer prior to the test that is failing.
If you could add a todo perhaps to change the constraint to 0.4.19 or higher as soon as the table widget is in. In 0.4.18 there were quite some issues with layer.events.data. In 0.4.19 there were still some but way less and we require these events for a properly working table widget.
melonora
reviewed
May 22, 2024
melonora
reviewed
May 22, 2024
|
Good to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colormapinstead ofcolorfrom0.5.0border_xxxinstead ofedge_xxxfrom the latestmain(unreleased, >0.5.0).This PR assumes that the next released version of napari is
0.5.0(the current is0.4.19). @melonora confirmed that this should be the case. If not, we need to adjust the version strings in this PR.Also, with @melonora we discussed if napari should automatically accept both the old argument and the new argument, as we do with our deprecation decorator approach: scverse/spatialdata#562. If it will, then we can remove the manual versions if-else checks added with this PR.