-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barebone annotate #233
base: main
Are you sure you want to change the base?
Barebone annotate #233
Conversation
for more information, see https://pre-commit.ci
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Open points from the test together (these are all mac specific):
Non mac specific
|
Small comment:
|
Bug:
|
I tested the saving (on the incremental io branch). I found some bugs:
Saving and overwriting work! |
Bug that I probably introduced here (I was working on performance in order to avoid copies) https://github.com/scverse/napari-spatialdata/pull/239/files in
|
for more information, see https://pre-commit.ci
…into barebone_annotate
not certain what you mean with the last point |
This PR serves to provide a barebone annotation widget. At the moment only shape annotations are supported but I am to extend this to points and perhaps labels as well. Furthermore, at a later stage also a table widget will be provided.
Currently, the user can annotate using and also reload shape annotations. The
description
column at the moment serves no purpose but this will come with the table widget.@LucaMarconato maybe before putting this in we need to discuss a little bit about UI experience.