Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix projectDir #486

Merged
merged 2 commits into from Nov 4, 2023
Merged

Fix projectDir #486

merged 2 commits into from Nov 4, 2023

Conversation

saundefined
Copy link
Contributor

@saundefined saundefined commented Oct 7, 2023

@beryllium in alpha2 I've encountered that the config is not loading properly
(e.g. $this->configuration->get('title') or {{ site.title }} was missing),
this should help.

Added a test to proof it.

@beryllium beryllium merged commit d15ce70 into sculpin:main Nov 4, 2023
3 checks passed
@beryllium
Copy link
Member

Thanks! I was just observing & debugging this issue this evening for the first time, I must have missed the PR when it first came in.

@saundefined saundefined deleted the fix-project-dir branch November 4, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants