Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony 5.4 #485

Merged
merged 3 commits into from Oct 7, 2023
Merged

Use Symfony 5.4 #485

merged 3 commits into from Oct 7, 2023

Conversation

saundefined
Copy link
Contributor

Updated the Symfony packages to 5.4,
when we drop PHP 7.4, we can upgrade the packages to 6.3.

@beryllium, what do you think?

@saundefined saundefined marked this pull request as ready for review October 3, 2023 16:04
@beryllium
Copy link
Member

This is great, thanks!

Took me a little bit to get my system ready to test it (and I had to update my "icelus" thumbnail bundle along the way, since 5.4 introduces a change to the dependency injection component.)

BTW, if folks encounter that dependency injection issue:

  • In 5.4, the TreeBuilder requires a name as the first argument. For icelus, this name was the name of the root node, icelus.
  • The root node variable can now be populated by calling $tree->getRootNode().

In effect, this:

public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder;
        $rootNode = $treeBuilder->root('icelus');

Becomes this:

public function getConfigTreeBuilder()
    {
        $treeBuilder = new TreeBuilder('icelus');
        $rootNode = $treeBuilder->getRootNode();

@beryllium beryllium merged commit 31bfd45 into sculpin:main Oct 7, 2023
3 checks passed
@saundefined saundefined deleted the symfony-54 branch October 7, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants