phpstan fixes #459

beryllium · 2021-02-24T06:37:58Z

This fixes about 14 issues that PHPStan complained about.

Still to be resolved:

NodeDefinition weirdness
EventDispatcher weirdness
Several implementations of ArrayAccess without docblocks to indicate mixed return types makes phpstan grumpy
A few if statements that phpstan insists are superfluous, but it might be misunderstanding the algorithm

- This may not make contextual sense. Sometimes tools mislead, in this case PHPStan was being a bit insistent. But conceptually, this does seem to be a good practice.

beryllium added 5 commits February 23, 2021 22:30

Update command return types on execute()

2c7e9c0

Factor out unnecessary helperset

18330e1

Fix inaccurate docblock @param/@return/@var types

2882463

Switch to depending on the interface, not the concrete Configuration

a839451

- This may not make contextual sense. Sometimes tools mislead, in this case PHPStan was being a bit insistent. But conceptually, this does seem to be a good practice.

De-complexify this method and remove the unnecessary break;

e986c46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

phpstan fixes #459

phpstan fixes #459

beryllium commented Feb 24, 2021

phpstan fixes #459

Are you sure you want to change the base?

phpstan fixes #459

Conversation

beryllium commented Feb 24, 2021