Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #318 - try and include autoload.php from vendor/bin directory i… #319

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

steverhoades
Copy link

…f installed via composer

@steverhoades
Copy link
Author

Ref sculpin/sculpin.io#99 as these instructions will not work until this PR is merged.

@Xerkus
Copy link
Member

Xerkus commented Feb 24, 2017

@steverhoades are you on mac?
php 7 on fedora here, __DIR__ is resolving to actual file location, not the symlink location

@steverhoades
Copy link
Author

@Xerkus Yes, I use a mac with PHP 7. Is this fix causing an issue for you?

@Xerkus
Copy link
Member

Xerkus commented Feb 25, 2017

no problem for me
echo __DIR__; without any fix in bin files gives me this:

[Xerkus@xerkus-laptop blog (sculpin *)]$ vendor/bin/sculpin
/home/Xerkus/workspace/blog/vendor/sculpin/sculpin/bin

i guess it have to be the way php handles symbolic links on mac.

@Xerkus
Copy link
Member

Xerkus commented Mar 1, 2017

@steverhoades can you catch me on irc about this? i suspect there might be something else at fault here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants