Improve content type bundle's configuration. #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is still a work in progress and will probably be rebased soon.
I'm rewriting SculpinContentTypesExtension as an exercise in becoming more acquainted with it. The outcomes of this work are:
services.xml
and then concrete implementations are added in the extension for each configured type.FilterPass
adds tagged filter services to the ChainFilter for each type.What's not great about this pull request:
services.xml
and the extension is still a bit uncertain. Most of the services are private and abstract and their configuration is incomplete. If more can be done in the configuration file, perhaps less needs to be done in the extension.What I still want to do:
FilterPass
because it's weird and messy.