Set stroke-linejoin and stroke-linecap to "round" for gradient strokes in 2.0 SVGs #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
changed the title
adroitwhiz
force-pushed
the
fix-linejoin
branch
from
99583fc
to
04f50e7
Compare
fsih
reviewed
Jan 29, 2020
adroitwhiz
force-pushed
the
fix-linejoin
branch
from
04f50e7
to
9189735
Compare
adroitwhiz
force-pushed
the
fix-linejoin
branch
from
9189735
to
e6cc9fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves the rest of scratchfoundation/scratch-render#194
Resolves scratchfoundation/scratch-paint#394
Proposed Changes
This PR adds another function to SvgRenderer which rounds all strokes with a gradient color. This function is only called for 2.0 ("version 2") SVGs. It also changes
SvgRenderer._collectElementsto allow the caller to optionally collect all elements, which I used in the stroke-rounding function.Reason for Changes
In Scratch 2.0, for some inexplicable reason, all strokes with a gradient color have rounded joins and caps:
This is relied upon in things like the text bubble from project #186282308: