New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS Secret Manager for DB credentials #135
base: main
Are you sure you want to change the base?
Conversation
Hi @poundifdef, can you please review this PR ? |
Hi @poundifdef, I have resolved the above comments. Can you please review ? |
Hi @poundifdef , can you please review the updated changes ? |
I haven't forgotten, I'll be sure to let you know when I've tested. Thanks! |
Sure @poundifdef 👍 |
Hi @poundifdef, There appear to be a lot of structural changes on main branch. My work was based on the old structure as described by you in the issue description. Can you tell if the requirements are a bit changed now ? Could you please provide an update on the direction we are heading with regard to this issue? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct that the project structure has changed on the main
branch, however, it is okay for you to keep the current structure of the code. I will handle rebasing myself.
@poundifdef I have resolved your comments. Please have a look. |
@poundifdef are we good to go with the updated changes ? |
Looks good. Thank you. |
/claim #126
/fixes #126
Hi @poundifdef, I have tested out the memory vault & aws vault & it is working as expected.
The aws config looks like this :