Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Secret Manager for DB credentials #135

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mehulmathur16
Copy link
Contributor

/claim #126
/fixes #126

Hi @poundifdef, I have tested out the memory vault & aws vault & it is working as expected.

The aws config looks like this :

vault:
  type: aws
  settings:
    AccessKey: "YOUR_AWS_ACCESS_KEY"
    SecretKey: "YOUR_AWS_SECRET_KEY"
    Prefix: "YOUR_PREFIX"
    Region: "us-east-1"

@mehulmathur16
Copy link
Contributor Author

The below video shows the working with both vaults.

470c533d-f1c9-46f9-b545-71e499f210a1.mp4

On AWS console:

image image

@mehulmathur16
Copy link
Contributor Author

Hi @poundifdef, can you please review this PR ?

pkg/storage/vault/aws/aws.go Outdated Show resolved Hide resolved
pkg/storage/vault/aws/aws.go Outdated Show resolved Hide resolved
pkg/storage/vault/aws/aws.go Outdated Show resolved Hide resolved
pkg/storage/vault/vault.go Outdated Show resolved Hide resolved
pkg/destinations/destinations.go Outdated Show resolved Hide resolved
@mehulmathur16
Copy link
Contributor Author

Hi @poundifdef, I have resolved the above comments. Can you please review ?

@mehulmathur16
Copy link
Contributor Author

Hi @poundifdef , can you please review the updated changes ?

@poundifdef
Copy link
Contributor

I haven't forgotten, I'll be sure to let you know when I've tested. Thanks!

@mehulmathur16
Copy link
Contributor Author

Sure @poundifdef 👍

@mehulmathur16
Copy link
Contributor Author

mehulmathur16 commented Mar 29, 2024

Hi @poundifdef, There appear to be a lot of structural changes on main branch. My work was based on the old structure as described by you in the issue description. Can you tell if the requirements are a bit changed now ?

Could you please provide an update on the direction we are heading with regard to this issue?

Copy link
Contributor

@poundifdef poundifdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct that the project structure has changed on the main branch, however, it is okay for you to keep the current structure of the code. I will handle rebasing myself.

pkg/storage/vault/aws/aws.go Outdated Show resolved Hide resolved
pkg/storage/vault/memory/memory.go Show resolved Hide resolved
pkg/storage/vault/aws/aws.go Outdated Show resolved Hide resolved
@mehulmathur16
Copy link
Contributor Author

@poundifdef I have resolved your comments. Please have a look.

@mehulmathur16
Copy link
Contributor Author

mehulmathur16 commented Apr 2, 2024

@poundifdef are we good to go with the updated changes ?

@poundifdef
Copy link
Contributor

Looks good. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a AWS Secret Manager for DB credentials
2 participants