fix test expectations #6316
Merged
fix test expectations #6316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6316 +/- ##
==========================================
- Coverage 83.92% 83.88% -0.05%
==========================================
Files 161 161
Lines 11972 11972
Branches 1865 1927 +62
==========================================
- Hits 10048 10043 -5
- Misses 1588 1594 +6
+ Partials 336 335 -1 |
Gallaecio
reviewed
Apr 17, 2024
Gallaecio
approved these changes
Apr 17, 2024
wRAR
reviewed
Apr 17, 2024
tests/test_utils_python.py
Outdated
| @@ -239,8 +239,11 @@ def __call__(self, a, b, c): | |||
| self.assertEqual(get_func_args(" ".join, stripself=True), ["iterable"]) | |||
|
|
|||
| if platform.python_implementation() == "CPython": | |||
| # doesn't work on CPython: https://bugs.python.org/issue42785 | |||
| self.assertEqual(get_func_args(operator.itemgetter(2)), []) | |||
| # Didn't used to work on CPython: https://bugs.python.org/issue42785 | |||
There was a problem hiding this comment.
wRAR
reviewed
Apr 17, 2024
tests/test_utils_python.py
Outdated
| @@ -239,8 +239,11 @@ def __call__(self, a, b, c): | |||
| self.assertEqual(get_func_args(" ".join, stripself=True), ["iterable"]) | |||
|
|
|||
| if platform.python_implementation() == "CPython": | |||
| # doesn't work on CPython: https://bugs.python.org/issue42785 | |||
| self.assertEqual(get_func_args(operator.itemgetter(2)), []) | |||
| # This never worked on CPython: https://bugs.python.org/issue42785 | |||
There was a problem hiding this comment.
Well it didn't work but now works :) How about "This didn't work on older versions of CPython"?
Also I would update the issue URL to python/cpython#86951
wRAR
approved these changes
Apr 17, 2024
|
Thanks! |
|
Should I make a similar PR for scrapy/itemloaders#76? |
That would be awesome! |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6312