Follow vorboto/feature/httpcompression keeep response encoding #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpression_keeep_response_encoding
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6156 +/- ##
=======================================
Coverage 88.59% 88.60%
=======================================
Files 159 159
Lines 11582 11591 +9
Branches 1885 1886 +1
=======================================
+ Hits 10261 10270 +9
Misses 994 994
Partials 327 327
|
|
@Gallaecio @wRAR would be happy if you would review it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a try for issue #1988.
it is based on this PR: https://github.com/scrapy/scrapy/pull/4025/files
Made my own branch based on old PR. Updated branch with scrapy/scrapy's master.
Changed the way of how proposed setting is used in HttpCompressionMiddleware's init.