Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookies test #6141

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions tests/mockserver.py
Expand Up @@ -200,6 +200,18 @@ def render_GET(self, request):
render_POST = render_GET


class Echo2(LeafResource):
def render_GET(self, request):
req = json.loads(request.content.read())

request.setResponseCode(req.get("status", 200))
for k, v in req.get("headers").items():
request.setHeader(bytes(k, encoding="utf8"), bytes(v, encoding="utf8"))
return bytes(req.get("body", "<html></html>"), encoding="utf8")

render_POST = render_GET


class RedirectTo(LeafResource):
def render(self, request):
goto = getarg(request, b"goto", b"/")
Expand Down Expand Up @@ -249,6 +261,7 @@ def __init__(self):
self.putChild(b"drop", Drop())
self.putChild(b"raw", Raw())
self.putChild(b"echo", Echo())
self.putChild(b"echo2", Echo2())
self.putChild(b"payload", PayloadResource())
self.putChild(
b"xpayload",
Expand Down
73 changes: 73 additions & 0 deletions tests/test_cookies.py
@@ -0,0 +1,73 @@
import json

from twisted.internet import defer
from twisted.trial.unittest import TestCase

from scrapy.crawler import CrawlerRunner
from scrapy.http import Request
from tests.mockserver import MockServer
from tests.spiders import MetaSpider


class CookiesSpider(MetaSpider):
name = "cookies"

def start_requests(self):
url = self.mockserver.url("/echo2/")
for status in [200, 302, 503]:
# Response params that mockserver will return
body = {
"status": status,
"headers": {
"Set-cookie": f"status={status}",
},
"body": "<html></html>",
}

if status == 302:
body["headers"]["location"] = self.mockserver.url("/")

yield Request(
url,
callback=self.parse,
meta={"cookiejar": status},
body=json.dumps(body),
)

def parse(self, response):
pass

def close(self, spider):
mw = [
m
for m in self.crawler.engine.downloader.middleware.middlewares
if "Cookies" in str(type(m))
][0]
jars_data = {}
for k, jar in mw.jars.items():
jars_data[k] = {
s: v.value for s, v in jar._cookies["127.0.0.1"]["/echo2"].items()
}
self.crawler.stats._stats["cookies_values"] = jars_data


class CookiesTestCase(TestCase):
def setUp(self):
self.mockserver = MockServer()
self.mockserver.__enter__()
self.runner = CrawlerRunner()

def tearDown(self):
self.mockserver.__exit__(None, None, None)

@defer.inlineCallbacks
def test_cookies(self):
crawler = CrawlerRunner().create_crawler(CookiesSpider)
yield crawler.crawl(mockserver=self.mockserver)
cookies_stats = crawler.stats._stats.get("cookies_values")
expected_cookies = {
200: {"status": "200"},
302: {"status": "302"},
503: {"status": "503"},
}
self.assertEqual(cookies_stats, expected_cookies)