New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Content-Encoding header in response flag #5943
base: master
Are you sure you want to change the base?
Add Content-Encoding header in response flag #5943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two tests are failing now, one because there is a new warning which it doesn't expect and another one probably because the header is dropped by default?
This PR is also missing the default setting value, docs and tests for the new setting. Some of those already exist in #5290 so it should be possible to copy them (though I haven't checked the test changes there).
Added values to default_settings.py for successful test runs |
@@ -37,7 +37,7 @@ | |||
COMMANDS_MODULE = "" | |||
|
|||
COMPRESSION_ENABLED = True | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should keep the empty line before CONCURRENT_ITEMS
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5943 +/- ##
===========================================
- Coverage 88.59% 42.48% -46.12%
===========================================
Files 159 163 +4
Lines 11582 11551 -31
Branches 1885 1880 -5
===========================================
- Hits 10261 4907 -5354
- Misses 994 6267 +5273
- Partials 327 377 +50
|
Can you please fix conflicts? |
Can you please always run tests locally before publishing? |
Fixes #1988, closes #4025, closes #5290