Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Content-Encoding header in response flag #5943

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

hassaan-naushahi
Copy link

@hassaan-naushahi hassaan-naushahi commented Jun 2, 2023

Fixes #1988, closes #4025, closes #5290

Copy link
Member

@wRAR wRAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tests are failing now, one because there is a new warning which it doesn't expect and another one probably because the header is dropped by default?

This PR is also missing the default setting value, docs and tests for the new setting. Some of those already exist in #5290 so it should be possible to copy them (though I haven't checked the test changes there).

@hassaan-naushahi
Copy link
Author

Added values to default_settings.py for successful test runs

@@ -37,7 +37,7 @@
COMMANDS_MODULE = ""

COMPRESSION_ENABLED = True

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should keep the empty line before CONCURRENT_ITEMS

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #5943 (8e76b5f) into master (70ba3a0) will decrease coverage by 46.12%.
The diff coverage is 23.33%.

❗ Current head 8e76b5f differs from pull request most recent head 32c7da5. Consider uploading reports for the commit 32c7da5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5943       +/-   ##
===========================================
- Coverage   88.59%   42.48%   -46.12%     
===========================================
  Files         159      163        +4     
  Lines       11582    11551       -31     
  Branches     1885     1880        -5     
===========================================
- Hits        10261     4907     -5354     
- Misses        994     6267     +5273     
- Partials      327      377       +50     
Files Coverage Δ
scrapy/settings/default_settings.py 98.80% <100.00%> (ø)
scrapy/downloadermiddlewares/httpcompression.py 37.50% <20.68%> (-52.21%) ⬇️

... and 145 files with indirect coverage changes

@wRAR
Copy link
Member

wRAR commented Sep 12, 2023

Can you please fix conflicts?

@wRAR
Copy link
Member

wRAR commented Dec 15, 2023

Can you please always run tests locally before publishing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Content-Encoding" header gets stripped from response headers
2 participants