improve the log configuration with using RotatingFileHandler #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4840 +/- ##
==========================================
- Coverage 87.85% 87.82% -0.04%
==========================================
Files 160 160
Lines 9735 9740 +5
Branches 1437 1438 +1
==========================================
+ Hits 8553 8554 +1
- Misses 925 928 +3
- Partials 257 258 +1
|
|
Could you make this optional, so the current behavior continues to be the default behavior? Also, please update the documentation and tests accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current log configuration makes only one log file that will become very big, i think its necessary to offer more options about this.
Resolves #3628