Process cookies from header only once #4812
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What if a retry (instead of a redirect) needs to happen, because the server sent e.g. a 503 response. Wouldn鈥檛 the retry miss some required cookies? |
Codecov Report
@@ Coverage Diff @@
## master #4812 +/- ##
==========================================
+ Coverage 87.52% 87.54% +0.02%
==========================================
Files 160 160
Lines 9761 9762 +1
Branches 1440 1440
==========================================
+ Hits 8543 8546 +3
+ Misses 955 954 -1
+ Partials 263 262 -1
|
I don't think it would, once the header cookies are processed they are stored in the corresponding cookiejar and added to the appropriate requests. It would be an interesting test case though. |
3 tasks
I think that this and other similar cases (like previously mentioned 302s) required to be covered by tests first (maybe implemented in separate pull request). It think it should be.. regular testcase with
|
Open
|
I am not able to reproduce this issue on recent master script.pyfrom scrapy import FormRequest
import scrapy
from scrapy.crawler import CrawlerProcess
class LoginSpider(scrapy.Spider):
name = 'login'
# allowed_domains = ['quotes.toscrape.com']
start_urls = ['http://quotes.toscrape.com/login']
def parse(self, response):
csrf_token = response.xpath('//input[@name="csrf_token"]/@value').get()
return FormRequest.from_response(
response,
# formname='',
# formcss='',
formxpath='//form',
formdata={
'csrf_token': csrf_token,
'username': 'admin',
'password': 'admin'
},
callback=self.after_login
)
def after_login(self, response):
logout = response.xpath("//a[text()='Logout']/text()").get()
self.logger.info(logout)
if __name__ == "__main__":
process = CrawlerProcess();
process.crawl(LoginSpider);
process.start()log_outputFrom this test and on test proposed on [WIP] #6141 I don't see issue with 302's mentioned on #4717 (comment) . Proposed tests rely on possibility to look into CookieJars stored in CookiesMiddleware variable which is not trivial as we don't have implementation of #1878 |
|
@Gallaecio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃毀 Work in progress 馃毀
A first approach to solving #4717. The idea is to process cookies from the header only once, the actual method of solving it can vary (meta key, request attribute, etc). I know it's not much, but I'd like your opinions @Gallaecio @kmike @wRAR.
The following spider works with this patch, while it breaks with the current master (5a38639) - I'm working on some tests to reproduce this behaviour.
Fixes #1992