Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie support for automap #69

Merged
merged 20 commits into from Mar 24, 2023
Merged

Conversation

Gallaecio
Copy link
Contributor

@Gallaecio Gallaecio commented Feb 25, 2023

To-do:

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #69 (7d49ce8) into main (fc3a527) will decrease coverage by 0.60%.
The diff coverage is 97.38%.

❗ Current head 7d49ce8 differs from pull request most recent head 6ffb124. Consider uploading reports for the commit 6ffb124 to get more accurate results

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   99.54%   98.94%   -0.60%     
==========================================
  Files           7        8       +1     
  Lines         435      571     +136     
==========================================
+ Hits          433      565     +132     
- Misses          2        6       +4     
Impacted Files Coverage Δ
scrapy_zyte_api/handler.py 97.88% <90.00%> (-1.32%) ⬇️
scrapy_zyte_api/_cookies.py 96.00% <96.00%> (ø)
scrapy_zyte_api/responses.py 98.92% <97.22%> (-1.08%) ⬇️
scrapy_zyte_api/_downloader_middleware.py 100.00% <100.00%> (ø)
scrapy_zyte_api/_params.py 100.00% <100.00%> (ø)
scrapy_zyte_api/_request_fingerprinter.py 97.36% <100.00%> (ø)

@Gallaecio Gallaecio marked this pull request as ready for review March 2, 2023 16:58
README.rst Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
@Gallaecio Gallaecio requested review from BurnzZ, kmike and wRAR March 2, 2023 17:27
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@kmike
Copy link
Member

kmike commented Mar 24, 2023

Thanks @Gallaecio! I've checked all the changes, and can't spot any issue 👍 This is a complex feature, so we both might be missing something, but it'd be found in a real-world usage. So, let's proceed. Great work!

@kmike kmike merged commit f4818d3 into scrapy-plugins:main Mar 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants