Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[429] Fix default templates non-subscriptable problem #451

Conversation

NiltonGMJunior
Copy link
Contributor

Replaces all instances of data.job.metadata[x] in the templates with data.job.metadata.get(x).

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (2d11fbf) to head (3bbea05).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   79.51%   79.51%           
=======================================
  Files          76       76           
  Lines        3237     3237           
  Branches      537      537           
=======================================
  Hits         2574     2574           
  Misses        593      593           
  Partials       70       70           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VMRuiz VMRuiz requested a review from curita May 16, 2024 06:36
Copy link
Member

@curita curita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

tests/contrib/actions/jobs/test_tags.py Show resolved Hide resolved
@VMRuiz VMRuiz merged commit 88b5b30 into scrapinghub:master Jun 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants