Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX #357: Bug using "unique_fields" on update #358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bvrignaud
Copy link
Contributor

This is a correction for the bug #357.

@bvrignaud
Copy link
Contributor Author

Is there any problem to apply my PR ?

@franciscofruiz
Copy link

Hello, there is still the bug #357. You already fixed it in BUGFIX , you changed
- if(!isset($row->$field_name))
+ if(!property_exists($row, $field_name)) and it worked fine.
rollbacked here: BUGFIX #396

@scoumbourdis
Copy link
Owner

I will test the pull request and get back with some feedback. It seems to complicated to just merge it to be honest. I have to do some proof of concepts first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants