Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for Testing Farm timeout #181

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add test for Testing Farm timeout #181

wants to merge 2 commits into from

Conversation

phracek
Copy link
Member

@phracek phracek commented May 2, 2024

Add test for Testing Farm timeout.

Check if timeout is handled properly

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.32%. Comparing base (fb7e267) to head (677e901).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #181       +/-   ##
===========================================
- Coverage   99.50%   88.32%   -11.19%     
===========================================
  Files           8       10        +2     
  Lines         608      685       +77     
  Branches       68       70        +2     
===========================================
  Hits          605      605               
- Misses          3       78       +75     
- Partials        0        2        +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jamacku jamacku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phracek You can lower the timeout to hit it faster.

.github/workflows/timeout-test.yml Show resolved Hide resolved
Check if timeout is handled properly

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
summary: Basic timeout test
execute:
how: tmt
duration: 10s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
duration: 10s
duration: 60s

Shouldn't this be 60 seconds? Because the sleep takes 60 seconds.

Co-authored-by: Jan Macku <jamacku@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants