Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: stats.normaltest/jarque_bera: add array-API support #20736

Merged
merged 6 commits into from
May 18, 2024

Conversation

mdhaber
Copy link
Contributor

@mdhaber mdhaber commented May 17, 2024

Reference issue

Toward gh-20544

What does this implement/fix?

Adds array API support to stats.normaltest and stats.jarque_bera.

Additional information

Draft to let gh-20085 merge first.
Will also address #20085 (comment) if we figure out what was going on there.

Next PR will rewrite all these tests.

@github-actions github-actions bot added scipy.stats enhancement A new feature or improvement labels May 17, 2024
@mdhaber mdhaber mentioned this pull request May 17, 2024
74 tasks
scipy/stats/_stats_py.py Outdated Show resolved Hide resolved
scipy/stats/_stats_py.py Outdated Show resolved Hide resolved
@mdhaber mdhaber changed the title ENH: stats.normaltest: add array-API support ENH: stats.normaltest/jarque_bera_test: add array-API support May 18, 2024
@mdhaber mdhaber changed the title ENH: stats.normaltest/jarque_bera_test: add array-API support ENH: stats.normaltest/jarque_bera add array-API support May 18, 2024
@lucascolley lucascolley changed the title ENH: stats.normaltest/jarque_bera add array-API support ENH: stats.normaltest/jarque_bera: add array-API support May 18, 2024
@@ -6308,31 +6310,22 @@ def test_input_validation(self):


class TestJarqueBera:
def test_jarque_bera_stats(self):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced with a stronger test.

@lucascolley lucascolley added the array types Items related to array API support and input array validation (see gh-18286) label May 18, 2024
@mdhaber mdhaber marked this pull request as ready for review May 18, 2024 13:20
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@j-bowhay j-bowhay added this to the 1.14.0 milestone May 18, 2024
@j-bowhay j-bowhay merged commit 3a2718a into scipy:main May 18, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
array types Items related to array API support and input array validation (see gh-18286) enhancement A new feature or improvement scipy.stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants