Implementation of HDAs #246
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Solved path bug * Update load.py * Fixed doc * Fixed Load.py * Update load.py * Added Data section in documentation * Update data.rst * Updated Readme.md
Fixed typo
gbarlacchi
reviewed
Jan 20, 2023
|
|
||
|
|
||
|
|
||
| def home_location_ma(traj, week_period=None, radius=None, mode='sjoin', show_progress=True): |
There was a problem hiding this comment.
I suggest to call this most_amount(..) and then it will be called as
from skmob.measures import home_detection
home_detection.most_amount(..)
gbarlacchi
reviewed
Jan 20, 2023
| return _uid_apply(_home_location_ma, traj, show_progress, week_period=week_period, radius=radius, mode=mode) | ||
|
|
||
|
|
||
| def home_location_tc(traj, week_period=None, start_time='22:00', end_time='07:00', radius=None, mode='sjoin', show_progress=True): |
There was a problem hiding this comment.
same comment as before. Let's use the name of the algorithm as a method name: time_constraint(..)
gbarlacchi
reviewed
Jan 20, 2023
| return (lat, lng) | ||
|
|
||
|
|
||
| def _home_location_ma(traj, week_period, radius, mode): |
There was a problem hiding this comment.
why do you have a private and a public method for each alg? Can't you just have everything in the same method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of several HDAs (Home Location Detection Algorithms) and related variants:
Most Amount / Maximum Amount
Time Constraint
Distinct Days
Inactivity