docstring initUncovered (candidate) + remove useless variables

scikit-mine · Mar 20, 2023 · 3d343fb · 3d343fb
1 parent de80582
commit 3d343fb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/skmine/periodic/candidate.py b/skmine/periodic/candidate.py
@@ -258,12 +258,15 @@ def updateCountCover(self, counts_cover):
 
     def initUncovered(self):
         """
-        FIXME : why the list of peer timestamps/events not covered by the candidate is equal to the list of occurrences
-                of the pattern?
+        Initializes the list of occurrences of the candidate pattern that are not covered by occurrences of other
+        patterns already selected.
+
+        The set "uncovered" corresponds to "occs(P)\\ O", initially no pattern is selected, O is empty, none of the
+        occurrences are covered. See : https://arxiv.org/pdf/1807.01706.pdf#page=29
 
         Returns
         -------
-
+        None
         """
         self.uncov = set(self.getEvOccs())
 

diff --git a/skmine/periodic/cycles.py b/skmine/periodic/cycles.py
@@ -198,7 +198,7 @@ def discover(self, dE_sum=True, chronological_order=True):
         """
 
         global_stat_dict, patterns_list_of_dict = self.miners_.output_detailed(
-            self.data_details, auto_time_scale_factor=10 ** self.n_zeros_ if self.auto_time_scale else 1)
+            self.data_details)
 
         if not patterns_list_of_dict:
             return pd.DataFrame()  # FIXME

diff --git a/skmine/periodic/pattern_collection.py b/skmine/periodic/pattern_collection.py
@@ -232,7 +232,7 @@ def output_pattern_list_and_cost(self, data_seq, print_simple=True):
 
         return patterns_list_of_dict, cl
 
-    def output_detailed(self, data_seq, print_simple=True, auto_time_scale_factor=1):
+    def output_detailed(self, data_seq, print_simple=True):
         nbs = self.nbPatternsByType()
         data_details = data_seq.getDetails()