Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Follow-up inverse_transform standardization and deprecation clean-up #28932

Merged

Conversation

jeremiedbb
Copy link
Member

There's a mention of old W param of NMF's inverse_transform that was not updated in #28756, which should now be Xt (deprecated W was removed but now Xt is deprecated in favor of X).

@jeremiedbb jeremiedbb added the Quick Review For PRs that are quick to review label May 2, 2024
@jeremiedbb jeremiedbb added this to the 1.5 milestone May 2, 2024
Copy link

github-actions bot commented May 2, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 7de12e3. Link to the linter CI: here

Copy link
Contributor

@OmarManzoor OmarManzoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jeremiedbb jeremiedbb merged commit c5aa12b into scikit-learn:main May 3, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:decomposition Quick Review For PRs that are quick to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants