DOC persistence page revamp #28889
Merged
DOC persistence page revamp #28889
+349
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting this on the milestone since it'd be very nice to have the revamped page on the release. |
glemaitre
reviewed
Apr 26, 2024
doc/model_persistence.rst
Outdated
|
|
||
| |details-start| | ||
| **Using ``pickle``, ``joblib``, or ``cloudpickle``** |
There was a problem hiding this comment.
The rendering will be better.
Suggested change
| **Using ``pickle``, ``joblib``, or ``cloudpickle``** | |
| **Using pickle, joblib, or cloudpickle** |
There was a problem hiding this comment.
Sure, but then they have to be un-bolded
ogrisel
reviewed
Apr 29, 2024
lorentzenchr
approved these changes
Apr 29, 2024
| :mod:`skops.io` avoids using :mod:`pickle` and only loads files which have types | ||
| and references to functions which are trusted either by default or by the user. | ||
| Therefore it provides a more secure format than :mod:`pickle`, :mod:`joblib`, |
There was a problem hiding this comment.
Is it a human-readable format?
There was a problem hiding this comment.
Inside the zipfile, there's a human readable schema, but one needs to know a bunch about the format to look at it.
|
@ogrisel is this good to merge? |
|
I'm removing the milestone because it's just doc and can be backported in the appropriate branch anytime. |
Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revamps our persistence documentation page to make it coherent and closer to what we actually expect users to do.
Two points:
PMMLsince I don't see it being very relevant these days.cloudpicklesince I've seen it in cases where people need to persist arbitrary user defined functions.cc @glemaitre @ArturoAmorQ