Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] Engine plugin API and engine entry point for Lloyd's KMeans #24497

Closed
wants to merge 79 commits into from
Closed

[DRAFT] Engine plugin API and engine entry point for Lloyd's KMeans #24497

wants to merge 79 commits into from

Commits on Mar 29, 2022

  1. wip engines

    @ogrisel
    ogrisel committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    e209cb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. wip

    @ogrisel
    ogrisel committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    1647eed View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. fixes

    @ogrisel
    ogrisel committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    87654c1 View commit details
    Browse the repository at this point in the history

  2. wip

    @ogrisel
    ogrisel committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    b05d4ab View commit details
    Browse the repository at this point in the history

  3. more specific assertion

    @ogrisel
    ogrisel committed Apr 4, 2022
    Configuration menu
    Copy the full SHA
    828f797 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Add docstring to the config context

    @ogrisel
    ogrisel committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    5819524 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. add default kwarg

    @ogrisel
    ogrisel committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    5df598c View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Various fixes

    @ogrisel
    ogrisel committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    44cbd6c View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2022

  1. empty doc

    @ogrisel
    ogrisel committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    a693d2e View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Merge branch 'main' into wip-engines

    @ogrisel
    ogrisel committed May 19, 2022
    Configuration menu
    Copy the full SHA
    e57eae7 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2022

  1. WIP

    @ogrisel
    ogrisel committed May 21, 2022
    Configuration menu
    Copy the full SHA
    1dbae5b View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Merge branch 'main' into wip-engines

    @ogrisel
    ogrisel committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    ec6baa0 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. wip

    @ogrisel
    ogrisel committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    dd586f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Move tolerance computation to the engine

    @ogrisel
    ogrisel committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    e3c1056 View commit details
    Browse the repository at this point in the history

  2. wip

    @ogrisel
    ogrisel committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    bd280ef View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Merge branch 'main' into wip-engines

    @ogrisel
    ogrisel committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4913f9b View commit details
    Browse the repository at this point in the history

  2. wip

    @ogrisel
    ogrisel committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    3352c58 View commit details
    Browse the repository at this point in the history

  3. wip

    @ogrisel
    ogrisel committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4753143 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. linting

    @fcharras
    fcharras committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    2794d26 View commit details
    Browse the repository at this point in the history

  2. fix MBKMeans and linting

    @fcharras
    fcharras committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    cc36c6e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into wip-engines

    @ogrisel
    ogrisel committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    80d4ba4 View commit details
    Browse the repository at this point in the history

  4. Draft changelog entry

    @ogrisel
    ogrisel committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    f92d63f View commit details
    Browse the repository at this point in the history

  5. doc reorg

    @ogrisel
    ogrisel committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    dbf607b View commit details
    Browse the repository at this point in the history

  6. fix changelog entry to add the pr number

    @ogrisel
    ogrisel committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    abb278a View commit details
    Browse the repository at this point in the history

  7. fix test name

    @ogrisel
    ogrisel committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    c1e8510 View commit details
    Browse the repository at this point in the history

  8. attempt at sphinx the sphinx warning

    @ogrisel
    ogrisel committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    9408280 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. fix MBKMeans test

    @fcharras
    fcharras committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    1fc4d79 View commit details
    Browse the repository at this point in the history

  2. fix: skip entry points that do not match the requested provider names… 

    … (rather than the opposite)
    @fcharras
    fcharras committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    acc4b47 View commit details
    Browse the repository at this point in the history

  3. update config_context unit test to account for new engine_provider ke… 

    …yword
    @fcharras
    fcharras committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    d0d7f95 View commit details
    Browse the repository at this point in the history

  4. for python < 3.10 returns an empty list when the slearn engines entry… 

    … point is missing (rather than erroring out))
    @fcharras
    fcharras committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    dcb3140 View commit details
    Browse the repository at this point in the history

  5. Link to user guide from docstring

    @ogrisel
    ogrisel committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    8df26c7 View commit details
    Browse the repository at this point in the history

  6. add a verbosity parameter to get_engine_class

    @fcharras
    fcharras committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    db7b98c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. add pytest plugin that can be used by engine providers to run sklearn… 

    … tests with customised engines
    @fcharras
    fcharras committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    4a379d2 View commit details
    Browse the repository at this point in the history

  2. Add plugin methods for predict, transform and score methods for KMeans

    @fcharras
    fcharras committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    12fc503 View commit details
    Browse the repository at this point in the history

  3. ad _engine.base module

    @fcharras
    fcharras committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    da5fe85 View commit details
    Browse the repository at this point in the history

  4. linting

    @fcharras
    fcharras committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    53cb8f1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i… 

    …nto wip-engines
    @fcharras
    fcharras committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    7cb4712 View commit details
    Browse the repository at this point in the history

  6. fix a bug that caused by the pytest plugin where sklearn tests would … 

    …be executed twice
    @fcharras
    fcharras committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    d72050f View commit details
    Browse the repository at this point in the history

  7. __all__fixup and renaming FeatureNotCoveredByPluginError -> NotSuppor… 

    …tedByEngineError
    @fcharras
    fcharras committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    a299bd8 View commit details
    Browse the repository at this point in the history

  8. exception __all__ fixup

    @fcharras
    fcharras committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    2d08a91 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. register the _engine subpackage in setup.py

    @fcharras
    fcharras committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    70e4ecf View commit details
    Browse the repository at this point in the history

  2. add __init__.py

    @fcharras
    fcharras committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    54d1924 View commit details
    Browse the repository at this point in the history

  3. fix test_engines test

    @fcharras
    fcharras committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    1a805d7 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. fix _config.py conflicts

    @fcharras
    fcharras committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    e8c5193 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. Merge branch 'main' into wip-engines

    @jjerphan
    jjerphan committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    44cc071 View commit details
    Browse the repository at this point in the history

  2. fixup! Merge branch 'main' into wip-engines

    @jjerphan
    jjerphan committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    3b99c29 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. add engine method to get nb of distinct clusters

    @fcharras
    fcharras committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    39d10cd View commit details
    Browse the repository at this point in the history

  2. Merge branch 'wip-engines' of https://github.com/ogrisel/scikit-learn … 

    …into wip-engines
    @fcharras
    fcharras committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    a13efc9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/scikit-learn/scikit-learn i… 

    …nto wip-engines
    @fcharras
    fcharras committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    57f095f View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
    @fcharras @jjerphan
    fcharras and jjerphan committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    8b974c7 View commit details
    Browse the repository at this point in the history

  5. linting

    @fcharras
    fcharras committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    5550f40 View commit details
    Browse the repository at this point in the history

  6. fix

    @fcharras
    fcharras committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    f570f45 View commit details
    Browse the repository at this point in the history

  7. fix

    @fcharras
    fcharras committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    fdaf97b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Merge branch 'main' into wip-engines

    @betatim
    betatim committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    ab00912 View commit details
    Browse the repository at this point in the history

  2. Add support for trying engines in turn 

    Users can specify a list of engine providers to try, this change makes
it so we try them in order until one is found that accepts the request.
    @betatim
    betatim committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    b770bea View commit details
    Browse the repository at this point in the history

  3. Fix formatting

    @betatim
    betatim committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    76fd41b View commit details
    Browse the repository at this point in the history

  4. Update mean_variance computation

    @betatim
    betatim committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    dd0d0ff View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Move changelog entry to v1.3.rst

    @ogrisel
    ogrisel committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    10c599c View commit details
    Browse the repository at this point in the history

  2. Merge main

    @ogrisel
    ogrisel committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    ab1e34d View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Pass sample_weight parameter 

    Co-authored-by: Franck Charras <29153872+fcharras@users.noreply.github.com>
    @betatim @fcharras
    betatim and fcharras committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    ff191e2 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Add engine aware mixin to factor out engine stuff

    @betatim
    betatim committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    d74d652 View commit details
    Browse the repository at this point in the history

  2. Add attribute conversion decorator

    @betatim
    betatim committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    dfb3fe0 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. Tweak attribute conversion

    @betatim
    betatim committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    e531a6d View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Use Array API to get unique cluster count

    @betatim
    betatim committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    737c74f View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Rename cluster counting method

    @betatim
    betatim committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    a1ff1ec View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2023

  1. Update conversion related bits

    @betatim
    betatim committed Jan 13, 2023
    Configuration menu
    Copy the full SHA
    519ae67 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. Fix engine provider at fit time

    @betatim
    betatim committed Jan 16, 2023
    Configuration menu
    Copy the full SHA
    1a19de0 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Combine engine selection and validation

    @betatim
    betatim committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    96c5f9b View commit details
    Browse the repository at this point in the history

  2. Rename argument 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @betatim @ogrisel
    betatim and ogrisel committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    0c29cc2 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #14 from betatim/engines-cluster-count 

    Rename cluster counting method
    @ogrisel
    ogrisel committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    c7be19a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2023

  1. Merge branch 'main' into wip-engines

    @jjerphan
    jjerphan committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    56bf7b1 View commit details
    Browse the repository at this point in the history

  2. Rename loop variable 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @betatim @ogrisel
    betatim and ogrisel committed Jan 18, 2023
    Configuration menu
    Copy the full SHA
    48803d9 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Switch back to using accepts for engine selection

    @betatim
    betatim committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    6d1b390 View commit details
    Browse the repository at this point in the history

  2. Allow "runtime" engines to be passed as well as provider names

    @betatim
    betatim committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    157a9c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Update tests

    @betatim
    betatim committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    1441088 View commit details
    Browse the repository at this point in the history

  2. Update docstring for accepts

    @betatim
    betatim committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    68a64a8 View commit details
    Browse the repository at this point in the history

  3. Update comment for engine class config

    @betatim
    betatim committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    d9020e7 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Add engine_name attribute to ad-hoc engine classes 

    Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
    @betatim @ogrisel
    betatim and ogrisel committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    183068d View commit details
    Browse the repository at this point in the history

  2. Merge pull request #13 from betatim/engine-mixin

    @betatim
    betatim committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    39a39ad View commit details
    Browse the repository at this point in the history