New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Callback API continued #22000
Draft
jeremiedbb
wants to merge
26
commits into
scikit-learn:main
Choose a base branch
from
jeremiedbb:callback-api
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[WIP] Callback API continued #22000
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
272e75f
callback API
jeremiedbb 584bdf7
cln nmf and test reconstruction attributes
jeremiedbb bb32ff3
cln snapshot + test snapshot + uuid for computation tree
jeremiedbb 7a1825d
cln
jeremiedbb 3e3b25f
black
jeremiedbb 26dbb69
lint
jeremiedbb eb7b824
wip
jeremiedbb 9b913fd
Merge branch 'master' into callback-api
jeremiedbb f78442e
class
jeremiedbb 34bab15
more tests
jeremiedbb 596a58e
cln
jeremiedbb 4f9363c
wip
jeremiedbb 030f68b
Merge remote-tracking branch 'upstream/main' into callback-api
jeremiedbb 35c5284
wip
jeremiedbb 115e184
wip
jeremiedbb bdb4990
wip
jeremiedbb d1bb5eb
Merge remote-tracking branch 'upstream/main' into callback-api
jeremiedbb 7a43c30
wip
jeremiedbb 573fd5d
Merge remote-tracking branch 'upstream/main' into callback-api
jeremiedbb a218068
wip
jeremiedbb f794694
update poor_score
jeremiedbb ab74f19
Merge remote-tracking branch 'upstream/main' into pr/jeremiedbb/22000
jeremiedbb 37e569b
wip
jeremiedbb d7208fa
wip
jeremiedbb 774ff69
Merge remote-tracking branch 'upstream/main' into pr/jeremiedbb/22000
jeremiedbb b8ac1a5
cln
jeremiedbb File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,6 +89,7 @@ | |
|
||
__all__ = [ | ||
"calibration", | ||
"callback", | ||
"cluster", | ||
"covariance", | ||
"cross_decomposition", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# License: BSD 3 clause | ||
|
||
from ._base import BaseCallback | ||
from ._computation_tree import ComputationNode, ComputationTree, load_computation_tree | ||
from ._early_stopping import EarlyStopping | ||
from ._monitoring import Monitoring | ||
from ._progressbar import ProgressBar | ||
from ._snapshot import Snapshot | ||
from ._text_verbose import TextVerbose | ||
|
||
__all__ = [ | ||
"BaseCallback", | ||
"ComputationNode", | ||
"ComputationTree", | ||
"load_computation_tree", | ||
"Monitoring", | ||
"EarlyStopping", | ||
"ProgressBar", | ||
"Snapshot", | ||
"TextVerbose", | ||
] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be too magical to have only something call
_eval_callbacks_begin
and inspect internal the stack of calls to infer which method called this function.Of course it would make sense only if the same methods are expected to be called for fit/predict/etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's not obvious at all and I've not really thought about that. This first iteration is all about fit. I think it will be easier to not try to be too magical for now