Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST Ignore numpy warning until np.unique is fixed #20327

Merged
merged 1 commit into from
Jun 23, 2021
Merged

TST Ignore numpy warning until np.unique is fixed #20327

merged 1 commit into from
Jun 23, 2021

Conversation

thomasjpfan
Copy link
Member

This PR ignores the deprecation warning from np.unique for now until it is fixed in numpy. I opened a PR at: numpy/numpy#19301

ogrisel
ogrisel approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for tackling the upstream fix and the maintenance fix here!

The fix for the remaining failure has been merged concurrently.

@ogrisel ogrisel merged commit d6b7b51 into scikit-learn:main Jun 23, 2021
@lorentzenchr lorentzenchr mentioned this pull request Jun 23, 2021
Closed
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@thomasjpfan @samronsin
TST Ignore numpy warning for now (scikit-learn#20327)
edead87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogrisel ogrisel ogrisel approved these changes

Assignees
No one assigned
Labels
module:datasets No Changelog Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thomasjpfan @ogrisel