[WIP] Change print statements to logging #17808
Conversation
| @@ -39,6 +40,7 @@ | |||
| from ._k_means_elkan import elkan_iter_chunked_dense | |||
| from ._k_means_elkan import elkan_iter_chunked_sparse | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
There was a problem hiding this comment.
I think they want a global logger, like
logging.getLogger('sklearn')
|
Hi @rubywerman and @flosincapite I don't think there is a clear consensus on what we want to do on logging yet. It is likely it won't be a simple replacement of print by logging, see concerns raised in linked/related issues. |
|
Hi @rth ! @rubywerman and @lucylow have checked out the related issues. What would be the best way to proceed? Would a design document with a clear API proposal be a good first step? |
|
I think this issue is more involved then we thought it would be. See #78 (comment) |
|
Once we have a clear consensus and understanding of how we'd like to proceed, then we can divide the task and work on it. For now I think we can close this one and see how the discussion develops. |
Reference Issues/PRs
See #17439
What does this implement/fix? Explain your changes.
Change print statements to logging
Any other comments?
First stab at logging
@flosincapite