Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] MNT Replaces stream handler with null handler #15386

Closed
wants to merge 3 commits into from
Closed

[MRG] MNT Replaces stream handler with null handler #15386

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e32c4cd
BUG Removes logging configuration
thomasjpfan Oct 28, 2019
ef98729
ENH Uses nullhandler
thomasjpfan Oct 28, 2019
23a0ffa
ENH Do not configure logging level
thomasjpfan Oct 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions sklearn/__init__.py
View file
Open in desktop
Expand Up @@ -21,8 +21,7 @@
from ._config import get_config, set_config, config_context

logger = logging.getLogger(__name__)
logger.addHandler(logging.StreamHandler())
logger.setLevel(logging.INFO)
logger.addHandler(logging.NullHandler())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not remove the logger.addHandler line altogether and leave it to default handler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to do with the behavior of WARNING:

If the using application does not use logging, and library code makes logging calls, then (as described in the previous section) events of severity WARNING and greater will be printed to sys.stderr. This is regarded as the best default behaviour.

Anyways I am okay with removing the handler as well.



# Make sure that DeprecationWarning within this package always gets printed
Expand Down