Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX euclidean_distances float32 numerical instabilities #13554

Merged
merged 105 commits into from Apr 29, 2019

Commits on Mar 29, 2019

  1. vect vect euclidean

    jeremiedbb committed Mar 29, 2019
    Configuration menu
    Copy the full SHA
    d38d8a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. minmem

    jeremiedbb committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    01767d6 View commit details
    Browse the repository at this point in the history
  2. docstring

    jeremiedbb committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    83cada9 View commit details
    Browse the repository at this point in the history
  3. lint

    jeremiedbb committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    ecb3d2c View commit details
    Browse the repository at this point in the history
  4. unrelated

    jeremiedbb committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    6b140db View commit details
    Browse the repository at this point in the history
  5. update tests + fix int

    jeremiedbb committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    558b988 View commit details
    Browse the repository at this point in the history
  6. fix chunk size

    jeremiedbb committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    de9d217 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. fix sparse slice bounds

    jeremiedbb committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    395be7a View commit details
    Browse the repository at this point in the history
  2. fix what's new

    jeremiedbb committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    9c79570 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2019

  1. tmp

    jeremiedbb committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    4599379 View commit details
    Browse the repository at this point in the history
  2. use gen_batches

    jeremiedbb committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    7425821 View commit details
    Browse the repository at this point in the history
  3. nitpick

    jeremiedbb committed Apr 5, 2019
    Configuration menu
    Copy the full SHA
    a2504af View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2019

  1. Configuration menu
    Copy the full SHA
    fee1258 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. clearer comment

    jeremiedbb committed Apr 15, 2019
    Configuration menu
    Copy the full SHA
    fe74973 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2019

  1. Update doc/whats_new/v0.21.rst

    Co-Authored-By: jeremiedbb <34657725+jeremiedbb@users.noreply.github.com>
    glemaitre and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    7f5f257 View commit details
    Browse the repository at this point in the history
  2. Update doc/whats_new/v0.21.rst

    Co-Authored-By: jeremiedbb <34657725+jeremiedbb@users.noreply.github.com>
    glemaitre and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    46fb590 View commit details
    Browse the repository at this point in the history
  3. Update doc/whats_new/v0.21.rst

    Co-Authored-By: jeremiedbb <34657725+jeremiedbb@users.noreply.github.com>
    glemaitre and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    d8a2341 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e0a0dc5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4b6e707 View commit details
    Browse the repository at this point in the history
  6. FIX _estimate_mi discrete_features str and value check (scikit-learn#…

    …13497)
    
    * discrete_features str and value check
    
    * Update if logic
    
    * Add discrete_features bad str value test
    
    * Remove unnecessary nested isinstance str check
    
    * Add back nested isinstance str check
    
    * New/updates to tests
    
    * Add v0.21 whats new entry
    
    * Undo v0.21 whats new entry
    hermidalc authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    dd634db View commit details
    Browse the repository at this point in the history
  7. DOC Changed the docstring of class LinearSVR to reflect the default v…

    …alue of epsilon in the code (scikit-learn#13559)
    
    * Update docstring in LinearSVR
    
    Changed the docstring of class LinearSVR to reflect the default value of epsilon in the code.
    
    * Update tree.rst
    
    * Revert "Update tree.rst"
    mani2106 authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    0e916a5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    78cf2c6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1a96e1e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    46c4560 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    dbbd855 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    77b456f View commit details
    Browse the repository at this point in the history
  13. [MRG] Changed name n_components to n_connected_components in Agglomer…

    …ativeClustering base class (scikit-learn#13427)
    
    * Changed name n_components to n_connected_components in base class
    
    * Fixed line which exceeded PEP8 max of 79 chars
    
    * Fixed line 818 which exceeded PEP8 max of 79 chars
    
    * Added try and except to provide deprecation warning if  passed
    
    * Updated deprecation and removal version numbers
    
    * Added deprecation of n_components using @Property generator
    
    * Makes FeatureAgglomeration class inherit n_connected_components_ attribute from AgglomerativeClustering class
    
    * Added test for DeprecationWarning when trying to access n_components
    
    * Removed @Property generator causing linting error
    
    * Fixed typo in test
    
    * Fixed flake8 error due to single line between 2 functions
    
    * Test fix attempt
    
    * Edited test function docstring
    
    * Corrected n_components deprecation test docstring
    
    * Fixed line continuation issue in AgglomerativeClustering base class
    
    * Added deprecation message as part of the @deprecated decorator
    
    * Added  attribute deprecation information in the Attributes section of the AgglomerativeClustering base class docstring
    
    * Added test for deprecation warning message
    
    * Added  attribute deprecation information in the Attributes section of the FeatureAgglomeration base class docstring
    
    * Fixed test issue and added longer match string
    
    * Edited n_components_ deprecation message to add double backticks
    
    * Fixed match string to reflect deprecation message change in test
    
    * Added name to list of contributors
    
    * Documented information in v0.21 changelog
    
    * Added cluster parent folder to documentation in v0.21 changelog
    
    * Removed myself from list of core contributors
    
    * Moved |API| subsection to the end of the list, and changed reference to Github username
    
    * Removed n_components deprecation documentation from FeatureAgglomeration and AgglomerativeClustering class dosctrings
    
    * Fix indentation on _fix_connectivity function call
    Stéphane Couvreur authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    6dace0c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    37ef0c3 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    1d03e13 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    1d5dca9 View commit details
    Browse the repository at this point in the history
  17. DOC correct reference to target in load_linnerud docstring (scikit-le…

    …arn#13577)
    
    Minor correction to docstring of the function `load_linnerud()` in `base.py`, which was referring to 'targets' instead of 'target'.
    mwestt authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    bf1af7d View commit details
    Browse the repository at this point in the history
  18. FIX DummyEstimator when y is a 2d column vector (scikit-learn#13545)

    * Add column_or_1d to account for dataframe y
    
    * Add test
    
    * make the diff cleaner
    
    * switched pandas import for 2d array
    
    * change test to a simple comparison between 1d and 2d y
    
    * flake8 errors in tests
    
    * Add warning to acieve consistent behaviour as in other classifiers
    
    * Update whats new file
    
    * remove redundant code, fix regression
    
    * remove unnecessary import
    
    * add comment on test
    
    * address comments
    
    * fix what's new entry
    
    * Update doc/whats_new/v0.21.rst
    
    Co-Authored-By: adrinjalali <adrin.jalali@gmail.com>
    adrinjalali authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    b4fb670 View commit details
    Browse the repository at this point in the history
  19. FIX Take sample weights into account in partial dependence computatio…

    …n for gradient boosting (scikit-learn#13193)
    
    * Replace n_node_samples by weighted_n_node_samples in partial dependence computation
    
    * Add tests for both no-op and real sample weights
    
    * Improve naming and remove useless comment
    
    * Fix small test issues
    
    * Fix test for binary classification
    
    * Add test for regressions based on example from initial issue
    
    * Edit whats_new
    
    * 79
    
    * Simplify test code for regression partial dependence
    
    * PEP8
    
    * Facepalm
    
    * Refer to the public function in whats_new
    
    * Make the sample weight test standalone for further reuse
    
    * Fix PR number
    
    * Testing with L1 relative distance computed as averages
    
    * Testing element-wise
    
    * Fix and simplify unit test for binary classification
    
    * Clarify functional test
    samronsin authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    2de3969 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    800ecae View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    5eff972 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    5ebcef0 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    532f110 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    37ad253 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    984719c View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    d0b7441 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    14a3f16 View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    1fd5b71 View commit details
    Browse the repository at this point in the history
  29. TST Fixes to make test_pprint.py more resilient to change (scikit-lea…

    Stéphane Couvreur authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    7558d50 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    b4d0527 View commit details
    Browse the repository at this point in the history
  31. FEA VotingRegressor (scikit-learn#12513)

    Ramil Nugmanov authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    adceb7d View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    127cc41 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    37b099b View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    bdea46f View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    d91682a View commit details
    Browse the repository at this point in the history
  36. [MRG] DOC Correct coef_ shape in RidgeClassifier (scikit-learn#13633)

    * DOC Correct coef_ shape in RidgeClassifier
    
    * address review
    qinhanmin2014 authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    d7815e3 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    8a966f4 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    96ff3b0 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    c21be57 View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    c3e72f2 View commit details
    Browse the repository at this point in the history
  41. MAINT: n_jobs=-1 replaced with n_jobs=4 in tests (scikit-learn#13644)

    This change is to work around the hang
    
     scikit-learn#12263
    
    afflicting Windows on machines with > 62 hyperthreads.
    oleksandr-pavlyk authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    78cb1b3 View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    0e4f561 View commit details
    Browse the repository at this point in the history
  43. Configuration menu
    Copy the full SHA
    383b132 View commit details
    Browse the repository at this point in the history
  44. DOC typo in sklearn.utils.extmath.weighted_mode (scikit-learn#13655)

    1.5+2 = 3.5, not 3.
    Masstran authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    3801caf View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    5dc1c46 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    b928396 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    b957edd View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    c0fb225 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    95d39ca View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    f11f647 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    306d202 View commit details
    Browse the repository at this point in the history
  52. Fixing parameter description (for assume_centered) (scikit-learn#13456)

    * Fixing parameter description (for assume_centered)
    
    Fixing parameter description (for assume_centered)
    
    * Update shrunk_covariance_.py
    
    * Update empirical_covariance_.py
    falaktheoptimist authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    78c9cb5 View commit details
    Browse the repository at this point in the history
  53. MAINT Unvendor joblib (scikit-learn#13531)

    rth authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    66fa659 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    f229708 View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    6b29d38 View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    876908e View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    04fcbce View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    cc2c186 View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    02e864e View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    740c0fb View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    247f0e7 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    62b5a85 View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    3b54222 View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    63cd7d4 View commit details
    Browse the repository at this point in the history
  65. Configuration menu
    Copy the full SHA
    e8be8aa View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    78acc98 View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    2a2caff View commit details
    Browse the repository at this point in the history
  68. Configuration menu
    Copy the full SHA
    5a1f05a View commit details
    Browse the repository at this point in the history
  69. Configuration menu
    Copy the full SHA
    e5a8e0b View commit details
    Browse the repository at this point in the history
  70. Typo (scikit-learn#13693)

    jarrodmillman authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    0ca7c96 View commit details
    Browse the repository at this point in the history
  71. Configuration menu
    Copy the full SHA
    7005ab4 View commit details
    Browse the repository at this point in the history
  72. Configuration menu
    Copy the full SHA
    8e3cc5e View commit details
    Browse the repository at this point in the history
  73. MAINT: minor fix to whats_new (scikit-learn#13695)

    Thanks
    adrinjalali authored and jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    18dc3a9 View commit details
    Browse the repository at this point in the history
  74. Configuration menu
    Copy the full SHA
    32851c1 View commit details
    Browse the repository at this point in the history
  75. Configuration menu
    Copy the full SHA
    f818d86 View commit details
    Browse the repository at this point in the history
  76. Configuration menu
    Copy the full SHA
    32ea647 View commit details
    Browse the repository at this point in the history
  77. Configuration menu
    Copy the full SHA
    9cf6606 View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    8d4bffc View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    5135252 View commit details
    Browse the repository at this point in the history
  80. Configuration menu
    Copy the full SHA
    e15e391 View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    9a5b3ac View commit details
    Browse the repository at this point in the history
  82. Configuration menu
    Copy the full SHA
    77ac3df View commit details
    Browse the repository at this point in the history
  83. Configuration menu
    Copy the full SHA
    184cd2c View commit details
    Browse the repository at this point in the history
  84. Configuration menu
    Copy the full SHA
    fbcfc52 View commit details
    Browse the repository at this point in the history
  85. vect vect euclidean

    jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    e5e2848 View commit details
    Browse the repository at this point in the history
  86. merge

    jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    32c9f99 View commit details
    Browse the repository at this point in the history
  87. adress comments

    jeremiedbb committed Apr 25, 2019
    Configuration menu
    Copy the full SHA
    0f346f5 View commit details
    Browse the repository at this point in the history
  88. Configuration menu
    Copy the full SHA
    fce0713 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2019

  1. Configuration menu
    Copy the full SHA
    117529e View commit details
    Browse the repository at this point in the history
  2. Mib -> MiB

    jeremiedbb committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    9c205c1 View commit details
    Browse the repository at this point in the history
  3. back to copy=False

    jeremiedbb committed Apr 29, 2019
    Configuration menu
    Copy the full SHA
    985037a View commit details
    Browse the repository at this point in the history