Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MLSMOTE algorithm to imblearn #927

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

balvisio
Copy link

@balvisio balvisio commented Sep 21, 2022

What does this implement/fix? Explain your changes.

This is an implementation of the Multilabel SMOTE (MLSMOTE) algorithm described in the paper:

Charte, F. & Rivera Rivas, Antonio & Del Jesus, María José & Herrera, Francisco. (2015). MLSMOTE: Approaching imbalanced multilabel learning through synthetic instance generation. Knowledge-Based Systems. -. 10.1016/j.knosys.2015.07.019.

It is an oversampling technique that AFAIK there is no open-source implementation yet.

Addresses: #340

Any other comments?

The implementation is ready to be reviewed. Once reviewed, I can squash the commits for cleaner history.

balvisio and others added 24 commits September 18, 2022 10:06
Co-authored-by: Bruno Alvisio <bruno.alvisio@gmail.com>
Co-authored-by: Simon Ermler <simon_ermler@web.de>
@balvisio balvisio changed the title Ba/mlsmote Add MLSMOTE algorithm to imlearn Sep 21, 2022
@balvisio balvisio changed the title Add MLSMOTE algorithm to imlearn Add MLSMOTE algorithm to imblearn Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 97.19% // Head: 93.33% // Decreases project coverage by -3.86% ⚠️

Coverage data is based on head (70e1f96) compared to base (6176807).
Patch coverage: 95.11% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #927      +/-   ##
==========================================
- Coverage   97.19%   93.33%   -3.87%     
==========================================
  Files          97       96       -1     
  Lines        6348     6422      +74     
  Branches      711      582     -129     
==========================================
- Hits         6170     5994     -176     
- Misses        106      363     +257     
+ Partials       72       65       -7     
Impacted Files Coverage Δ
imblearn/over_sampling/_mlsmote.py 92.25% <92.25%> (ø)
imblearn/over_sampling/__init__.py 100.00% <100.00%> (ø)
imblearn/over_sampling/tests/test_mlsmote.py 100.00% <100.00%> (ø)
imblearn/keras/tests/test_generator.py 7.93% <0.00%> (-92.07%) ⬇️
imblearn/tensorflow/_generator.py 35.48% <0.00%> (-61.40%) ⬇️
imblearn/tests/test_docstring_parameters.py 30.93% <0.00%> (-56.84%) ⬇️
imblearn/tensorflow/tests/test_generator.py 10.75% <0.00%> (-54.84%) ⬇️
imblearn/keras/_generator.py 47.36% <0.00%> (-44.74%) ⬇️
imblearn/datasets/tests/test_zenodo.py 89.18% <0.00%> (-2.71%) ⬇️
imblearn/pipeline.py 93.47% <0.00%> (-1.09%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This was referenced Sep 21, 2022
@rjurney
Copy link

rjurney commented Sep 21, 2022

@balvisio Thank you! You are a scholar and a gentleman.

@balvisio
Copy link
Author

thank you @rjurney , my pleasure. Looking forward to any feedback.

@h-holm
Copy link

h-holm commented Nov 17, 2022

Thanks for the great work, @balvisio! Do we have any news on this PR?

@balvisio
Copy link
Author

Hello @h-holm , thank you. I am waiting for the maintainers to review the code so that the PR can be merged.

@h-holm
Copy link

h-holm commented Nov 18, 2022

Thanks for the update, @balvisio. Crossing my fingers that @glemaitre and others can chip in when time allows, as this would be a great addition 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants