Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

425 readme page broken #435

Merged
merged 32 commits into from May 13, 2024
Merged

425 readme page broken #435

merged 32 commits into from May 13, 2024

Conversation

LacombeLouis
Copy link
Collaborator

@LacombeLouis LacombeLouis commented Apr 19, 2024 •
edited by thibaultcordier

Description

Fix the read me logo failure.

Fixes #(issue)
Add the correct link to the logo

Please remove options that are irrelevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@LacombeLouis LacombeLouis self-assigned this Apr 19, 2024
@LacombeLouis LacombeLouis linked an issue Apr 19, 2024 that may be closed by this pull request
Readme page broken #425
Closed
LacombeLouis and others added 25 commits April 19, 2024 16:17
@LacombeLouis
Fix failing docs badge
d2bf6f8
@LacombeLouis
Update Python version classifiers in setup.py
faf31c6
@LacombeLouis
Test for workflow with python 3.12
746bdc2
@LacombeLouis
Merge branch 'master' into 425-readme-page-broken
c8b4b50
@LacombeLouis
chore: update miniconda version to "latest"
e80151a
@LacombeLouis
chore: update miniconda version to "latest"
21da7d9
@LacombeLouis
chore: update miniconda version to "latest"
796af77
@LacombeLouis
chore: update miniconda version to "latest"
44b1fec
@LacombeLouis
Update Python version classifiers in setup.py
cdbdfba
@LacombeLouis
chore: update miniconda version to latest stable
d720084
@LacombeLouis
FIX: Put lower threshold for difference
737bde9
@LacombeLouis
Update decimal number for test_calibration.py
19f5a06
@LacombeLouis
FIX: linting
34ddeda
@LacombeLouis
ADD: decimal precision and type fix
9e26425
@LacombeLouis
FIX: remove test due to changes in version 1.4.2 of _sigmoidcalibration
0e05d6e
@LacombeLouis
FIX: do not change python version
599d483
@BaptisteCalot @LacombeLouis
TRY Code changes without any impact to make a PR
23ba5bc
@BaptisteCalot @LacombeLouis
TRY Code changes without any impact to make a PR
3fa5dfb
@BaptisteCalot @LacombeLouis
TRY Code changes without any impact to make a PR
239faa3
@LacombeLouis
Update joblib dependency to version 1.3.2
bf42a5b
@LacombeLouis
Update joblib dependency to version 1.3.2
044a722
@LacombeLouis
FIX: possibe fix for issue with joblib and python version
296bf90
@LacombeLouis
FIX: make no changes
0410cdd
@LacombeLouis
FIX: make no changes to original file
983d50b
@LacombeLouis
chore: Update joblib dependency to version 1.3.2
8e9a910
thibaultcordier
thibaultcordier requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, which will tidy up the readme file. Just a few suggestions and questions before final approval.

README.rst Show resolved Hide resolved
environment.doc.yml Outdated Show resolved Hide resolved
thibaultcordier
thibaultcordier approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@thibaultcordier thibaultcordier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick changes! Ready to merge!

@LacombeLouis LacombeLouis merged commit cfbba58 into master May 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaultcordier thibaultcordier thibaultcordier approved these changes

@vincentblot28 vincentblot28 Awaiting requested review from vincentblot28

Assignees

@LacombeLouis LacombeLouis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readme page broken
3 participants
@LacombeLouis @thibaultcordier @BaptisteCalot