Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Adapt the split and cross strategies to quantile regression class #304

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

thibaultcordier
Copy link
Collaborator

@thibaultcordier thibaultcordier commented Apr 24, 2023

Description

At the moment, conformalized quantile regression has only been implemented with the split-conformal strategy. It would be worth extending it to cross-CQR with the cv argument. This PR proposes to adapt the quantile regression class for split and cross conformal strategies by adding to the init method the cv parameter so that it is comparable to the regression class.

Fixes #200

Type of change

Please remove options that are irrelevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Uniformisation of regression tests (for cross settings).
  • Adaptation of quantile regression tests to changes.

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@thibaultcordier thibaultcordier added the enhancement New feature or request label Apr 24, 2023
@thibaultcordier thibaultcordier self-assigned this Apr 24, 2023
@thibaultcordier thibaultcordier added this to In progress in Developments via automation Apr 24, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (963bb6e) 100.00% compared to head (3f6500b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #304   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines         3474      3399   -75     
  Branches       360       367    +7     
=========================================
- Hits          3474      3399   -75     
Impacted Files Coverage Δ
mapie/tests/test_utils.py 100.00% <ø> (ø)
mapie/utils.py 100.00% <ø> (ø)
mapie/quantile_regression.py 100.00% <100.00%> (ø)
mapie/regression.py 100.00% <100.00%> (ø)
mapie/tests/test_quantile_regression.py 100.00% <100.00%> (ø)
mapie/tests/test_regression.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft enhancement New feature or request
Projects
Developments
In progress
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Cross-CQR
3 participants