-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dev container config #7072
base: main
Are you sure you want to change the base?
Add dev container config #7072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good as a first glance. Is there some way to test this configuration out already or do we need to merge this first?
Ah, seems to work. There's actually a complete environment under |
"features": { | ||
"ghcr.io/devcontainers-contrib/features/pre-commit:2": {} | ||
}, | ||
"postCreateCommand": "pre-commit install && bash ./.devcontainer/postBuild", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised that pre-commit worked before the development setup in postBuild
. Seems like it is included in the container by default
$ which pre-commit
/usr/local/py-utils/bin/pre-commit
# Test your installation | ||
spin test | ||
# Build docs | ||
spin docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spin docs | |
spin docs | |
source ~/envs/skimage-dev/bin/activate | |
pre-commit install |
"features": { | ||
"ghcr.io/devcontainers-contrib/features/pre-commit:2": {} | ||
}, | ||
"postCreateCommand": "pre-commit install && bash ./.devcontainer/postBuild", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"postCreateCommand": "pre-commit install && bash ./.devcontainer/postBuild", | |
"postCreateCommand": "bash ./.devcontainer/postBuild", |
Just to be safe it may be good to use the pre-commit
in from the dev environment.
Hello scikit-image core devs! There hasn't been any activity on this PR for more than 180 days. I have marked it as "dormant" to make it easy to find. |
Adding config for scikit-image for the open spec, Development Containers, which allows tools like VS Code, Codespaces, JetBrains tools, DevPod, and hopefully more soon (GitPod?)
initially drafted this at SciPy 2023 sprints with @lagru <3
Checklist
✅ A descriptive but concise pull request title
✅ Docstrings for all functions
✅ Unit tests
✅ A gallery example in
./doc/examples
for new features✅ Contribution guide is followed
Release note
Summarize the introduced changes in the code block below in one or a few sentences. The
summary will be included in the next release notes automatically: