New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add write lhe file functions #233
Open
APN-Pucky
wants to merge
15
commits into
scikit-hep:main
Choose a base branch
from
APN-Pucky:write_lhe
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APN-Pucky
changed the title
feature: add write lhe file functions
feat: add write lhe file functions
Feb 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
==========================================
- Coverage 91.48% 91.17% -0.32%
==========================================
Files 2 2
Lines 235 306 +71
Branches 54 78 +24
==========================================
+ Hits 215 279 +64
- Misses 16 17 +1
- Partials 4 10 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
matthewfeickert
force-pushed
the
write_lhe
branch
from
March 20, 2024 22:36
7bfd160
to
ef0376f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to add a
tolhe()
function to every class (since it is neither xml nor a simple string).The format strings can maybe still be improved?
read_lhe_init()
now returns aLHEInit
object combining weights, procinfo and initinfo. For backwards compatibility I added the get/set there so thatLHEInit
will still behave as previousLHEInit
, what is nowLHEInitInfo
.The tests can probably still be extended, but for the first draft I just hardcoded them for one file.
Already includes #232 and #231
Closes: #229