Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update old code: CI, python version, pre-commit and unittests #36

Merged
merged 8 commits into from
May 21, 2024

Conversation

jonas-eschle
Copy link
Contributor

@jonas-eschle jonas-eschle commented May 25, 2022

This repo has a few modernizations outstanding, here we do the most important ones to upgrade it to modern Python and make sure the unittests run.

Amongst the changes are:

  • Upgrade to Python 3.10, drop 2.7
  • Add more pre-commit checks, black formatting
  • Update unittests, refactor helpers and replace "faulty" ones (?)

TODO:

  • Unexpected result of logical operators pydata/numexpr#408, as some logical operators give unexpected results. Seemingly, the cast to booleans is not explicitly possible currently (will be in NE3). This raises the question of changing to sympy maybe?
  • Some functions differ numerically in ROOT and numexpr. why?

@henryiii henryiii merged commit f1cf41a into master May 21, 2024
@henryiii henryiii deleted the ci/update-ci branch May 21, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants