Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend to CMAKE_MODULE_PATH if it already exists #1039

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

opoplawski
Copy link

Possible fix for #723 although it depends on setting an environment variable instead of just picking up CMAKE variables, though I'm not sure that is possible.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #1039 (d621450) into main (2ae7db8) will decrease coverage by 0.11%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1039      +/-   ##
==========================================
- Coverage   86.19%   86.09%   -0.11%     
==========================================
  Files          32       32              
  Lines        1579     1582       +3     
  Branches      351      352       +1     
==========================================
+ Hits         1361     1362       +1     
- Misses        155      156       +1     
- Partials       63       64       +1     
Files Coverage Δ
skbuild/cmaker.py 74.08% <33.33%> (-0.38%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant