Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use first available option for vswhere output #1030

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZzEeKkAa
Copy link

If multiple locations are returned next line check is failing since there is no folder that is a concatenation of two paths. That results in multiple installs for the same VS version treated as there is no one installed.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1030 (d56fc71) into main (676e110) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   86.19%   86.19%           
=======================================
  Files          32       32           
  Lines        1579     1579           
  Branches      351      351           
=======================================
  Hits         1361     1361           
  Misses        155      155           
  Partials       63       63           
Files Changed Coverage Δ
skbuild/platform_specifics/windows.py 87.50% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant