-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Elevating skbio.stats.xxx to 1st-level modules #1992
Open
qiyunzhu
wants to merge
18
commits into
scikit-bio:main
Choose a base branch
from
qiyunzhu:elevate
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1992 +/- ##
=======================================
Coverage 98.63% 98.63%
=======================================
Files 179 180 +1
Lines 30678 30679 +1
Branches 7456 7456
=======================================
+ Hits 30259 30260 +1
Misses 404 404
Partials 15 15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR elevates
skbio.stats.xxx
to 1st-level modules. Such that a user can dofrom skbio.composition import ancom
. Whereas the original entries are kept for backward compatibility. This PR also standardizes the organization of skbio modules. Now, every module occupies a 1st-level subdirectory, with its owntests
directory. This organization makes the codebase more modular. @wasade @mortonjt @mataton This is a proof-of-concept following our email discussion. I will follow up with a more detailed proposal of module organization.Update: Per @mortonjt 's suggestion, I have reverted
evolve
,gradient
,power
andsampling
back tostats
, and kept onlycomposition
,distance
, andordination
at the top level -- the three modules that deserve the most user attention.Please complete the following checklist:
I have read the contribution guidelines.
I have documented all public-facing changes in the changelog.
This pull request includes code, documentation, or other content derived from external source(s). If this is the case, ensure the external source's license is compatible with scikit-bio's license. Include the license in the
licenses
directory and add a comment in the code giving proper attribution. Ensure any other requirements set forth by the license and/or author are satisfied.This pull request does not include code, documentation, or other content derived from external source(s).
Note: This document may also be helpful to see some of the things code reviewers will be verifying when reviewing your pull request.