Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1143

Open
wants to merge 82 commits into
base: master
Choose a base branch
from
Open

Spelling #1143

wants to merge 82 commits into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 2, 2020

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

Note: Normally I exclude localizations. The only reason they're included is that I was migrating these changes from ProtonVPN/android-app#8 and hadn't excluded them yet. I'm happy to drop them if requested.

I try to exclude third party content. If I've missed something, please let me know, and if possible direct me to its upstream.

@schwabe
Copy link
Owner

schwabe commented Feb 2, 2020

I think changing spelling mistakes in licenses is wrong. The commits modify the openssl license.

@jsoref
Copy link
Contributor Author

jsoref commented Feb 2, 2020

I'll drop those later today.

Copy link
Contributor Author

@jsoref jsoref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schwabe are these the only license files that concerned you?

doc/LICENSE.txt Show resolved Hide resolved
main/src/main/assets/full_licenses.html Outdated Show resolved Hide resolved
main/src/main/assets/full_licenses.html Outdated Show resolved Hide resolved
main/src/main/assets/full_licenses.html Outdated Show resolved Hide resolved
main/src/main/assets/full_licenses.html Outdated Show resolved Hide resolved
@schwabe
Copy link
Owner

schwabe commented Feb 2, 2020

As a sidenote. 85 commits for the spelling is a lot. I will probably squash a few of them together before merging (unless you do it first).

Changing the localization keys will invalidate all the localisations in crowdin locatisation service. I am not sure if that is worth fixing the spelling mistakes. Have to think about that.

@jsoref
Copy link
Contributor Author

jsoref commented Feb 2, 2020

I can split that out to a distinct PR or however you request. I leave them as distinct commits while working on them because it makes it easier to drop things as a set (e.g. if i needed to drop the slider changes because you objected).

squashing/etc. is totally up to the project, I'm fairly flexible. I won't squash until (a) the build is green and (b) you're happy w/ things -- as it's fairly hard to unsquash, but trivial to squash...

@jsoref jsoref force-pushed the spelling branch 2 times, most recently from 9b2d4bf to 53c853e Compare February 3, 2020 00:20
@jsoref
Copy link
Contributor Author

jsoref commented Feb 3, 2020

ok, this is green. Let me know what you need done, and I can look into doing it (probably Tuesday).

@schwabe schwabe force-pushed the master branch 2 times, most recently from 08e55f3 to b55f007 Compare June 3, 2020 10:31
@schwabe schwabe force-pushed the master branch 6 times, most recently from 3ac849f to e4597ec Compare April 16, 2021 15:49
comradekingu added a commit to comradekingu/ics-openvpn that referenced this pull request Apr 11, 2022
@schwabe schwabe force-pushed the master branch 4 times, most recently from 2290b8d to f010753 Compare April 18, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants