Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid 64 #18

Open
wants to merge 15 commits into
base: paracosms
Choose a base branch
from
Open

Grid 64 #18

wants to merge 15 commits into from

Conversation

ergodicbreak
Copy link

@ergodicbreak ergodicbreak commented Dec 3, 2023 •
edited

Modifies grid support for 8x8 grids, per #16

I've highlighted some questions.

Changes:

  • code depends on variable grid_width instead of fixed number 16
  • 64 grids have 56 sample slots available
  • grid beat resolution is half beats rather than quarter beats (e.g. grid button [0][8] is beat four instead of two).

Not changed:

  • Sample loading; I'm assuming folders with more than eight samples are OK to load onto rows of 64 grids
  • Pset saving; I'm not sure if psets saved from a 64 grid session will load OK onto a 128 grid session, specifically because of beat resolution

I've commented the code (with TODO, DONE, and CHECK) and will clean everything up once the PR looks good.

Also I'm not that savvy with Github and pull requests and am a Lua beginner, so if I've messed anything up I am more than happy to correct it! Thanks.

@ergodicbreak
Created branch, outlined planned changes
25b5393
@ergodicbreak
Added TODOs where code obviously depends on fixed width of 16
b26b867
@ergodicbreak
changed new() to depend on grid_width rather than fixed number 16
9b66ba2
@ergodicbreak
test log to push from branch local on Shield
e70f964
@ergodicbreak
changing per width in init()
dd07de8
@ergodicbreak
changing per width in key_press()
4f078d6
@ergodicbreak
changing test based on id in get_visual() per width
52069ec
@ergodicbreak
completed todos in init()
69dcf18
@ergodicbreak
completed todos in key_press, with question re: id persistence
5d6aef7
@ergodicbreak
completed todos in get_visual
44f61e5
@ergodicbreak
removed test log
4e478aa
@ergodicbreak
completed todos in new()
2fd5397
@ergodicbreak
completed todos in get_visual
c15cce8 
midigrid 64 per https://llllllll.co/t/midigrid-use-launchpads-midi-grid-controllers-with-norns/42336/512
@ergodicbreak
check that loading more than eight samples/row for 64 grid is safe
13582e0
@ergodicbreak
Copy link
Author

After some more testing tonight something is not right with setting the sample start/end/duration from the grid, so I'm working on that.

@ergodicbreak
fix sample/start/end on grid
61f8356 
linear interpolation bug, the old value of 32 was based on two rows of
a 16 wide grid, scale according to grid width and it seems to work as expected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ergodicbreak