Fix wrong return type-hint depending on which symfony/translation version is installed #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you please check why phpunit is failing for sf 6.x? if it helps feel free to require 6.4 as min version |
…n version is installed
deguif
force-pushed
the
fix-wrong-contracts
branch
2 times, most recently
from
14887d2
to
c558b98
Compare
deguif
force-pushed
the
fix-wrong-contracts
branch
from
c558b98
to
2954a9d
Compare
|
I updated packages requirements only for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently type-hint is based on Kernel version, which in my case is wrong as we use individual package versioning (kernel is in version 5.4 but translation component is on 6.x version).
As the method
getCatalogueswas added toTranslatorBagInterfacein6.0, checking for this method should be better to handle this case.