Add the South Tyrol public transport #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service is provided by the province of Bolzano/Bozen (in northern Italy). The data are available under a CC0-license. The tests were adapted from the LinzAdapter ones
danielegobbetti
force-pushed
the
south-tyrol-STA
branch
from
02d0e2d
to
5505926
Compare
|
@grote a question for you since I noticed you are active here. I should wait until this is merged and transportr is updated to include the right commit, before opening the PR in transportr for its inclusion, right? |
|
@danielegobbetti I think it makes sense to wait for this to get merged. Then you can prepare a PR for Transportr (that also bumps the commit ID of PTE). |
|
@schildbach FYI my locally compiled Transportr is still working with the new provider, do you want me to test it with Öffi as well before merging? |
schildbach
force-pushed
the
master
branch
2 times, most recently
from
63d8043
to
2e5f16d
Compare
schildbach
force-pushed
the
master
branch
3 times, most recently
from
b017ce1
to
28dd2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service is provided by the province of Bolzano/Bozen (in northern Italy).
The data are available under a CC0-license, see http://dati.retecivica.bz.it/de/dataset/southtyrolean-public-transport
The tests were adapted from the LinzAdapter ones.
I verified that the data match with reality since I live there, please be aware that I only tested by building the android app Transportr and using my fork of the enabler library.
As I am by no means an expert of EFA, I don't know what the different setters do, if there are further tests I should perform I will happily follow instructions :-)