Navitia: Add Brazil providers #179
Conversation
Currently working in São Paulo, Rio de Janeiro, Belo Horizonte and Porto Allegre
| @@ -721,6 +721,9 @@ public NearbyLocationsResult queryNearbyLocations(final EnumSet<LocationType> ty | |||
|
|
|||
| try { | |||
| final JSONObject head = new JSONObject(page.toString()); | |||
| if (head.has("error")) { | |||
| return new NearbyLocationsResult(resultHeader, Status.INVALID_ID); | |||
| } | |||
There was a problem hiding this comment.
One of the live tests with an invalid station arrived here and head had no pagination, but an error.
There was a problem hiding this comment.
Maybe this change should go into a different PR that implements error handling for all Navitia calls?
There was a problem hiding this comment.
You seem to be merging PRs manually somehow. Couldn't you just split these 3 lines out into a separate commit when you do? I am happy to waive ownership on them.
|
What's the difference between the two providers. Is one of the datasets likely to be a superset of the other? |
|
The The |
schildbach
force-pushed
the
master
branch
2 times, most recently
from
63d8043
to
2e5f16d
Compare
schildbach
force-pushed
the
master
branch
3 times, most recently
from
b017ce1
to
28dd2c8
Compare
|
Any update on this? |
schildbach
added
the
navitia
|
I just merged the Navitia-based provider. The other one currently only throws errors. I must admit I'm a bit reluctant on merging – is there any chance this can go to Navitia too? If we continue, this needs a rebase. |
Currently working in São Paulo, Rio de Janeiro, Belo Horizonte and Porto Alegre.
Both providers have been used in Transportr already. Time to upstream.