Add support for Navitia Costa Rica provider. #146
Conversation
| */ | ||
| public class CostaRicaProviderLiveTest extends AbstractNavitiaProviderLiveTest { | ||
| public CostaRicaProviderLiveTest() { | ||
| super(new CostaRicaProvider(secretProperty("navitia.authorization"))); |
There was a problem hiding this comment.
If your server requires authorization (does it?), it is probably different from the one of the official navitia server, right? So in that case this should probably use a different secret variable here.
There was a problem hiding this comment.
This server does not require authorization and I don't think will be massively used. I think I could change the code, from "navitia.authorization" to null.
Also given that the server is administrated by a public university, no one disagree to keep it without authorization. Do you recommend to add the authorization?
There was a problem hiding this comment.
I personally don't like API secrets embedded in the source code. They are not secure anyway and don't work well with reproducible free software.
However, my point here was that this code above will attempt to use the secret property from the official navitia server. So it should either be removed or changed. Since your server doesn't require authorization, I'd just remove it. The live tests continue to work then, right?
There was a problem hiding this comment.
I have removed it. Thanks.
The tests continue working without the secrets.
|
As testing feedback, I used this PR code to generate a public-transport-enabler library, that later i used to compile Transportr (v1.1.8). Some screenshots of the app using the Costa Rica provider:
|
|
@jamescr do you have any students or other people using this regularly who can attest to the quality, so it can be included in PTE? If I understand correctly, such third-party attestations will help @schildbach whether to merge or not. |
|
I tested this apk version, And it's working pretty good |
schildbach
force-pushed
the
master
branch
2 times, most recently
from
63d8043
to
2e5f16d
Compare
schildbach
force-pushed
the
master
branch
3 times, most recently
from
b017ce1
to
28dd2c8
Compare
schildbach
added
enhancement
navitia
The Navitia server running is a locally installed version. This provider shares data from the Costa Rica Inter urban Train Network (Incofer Tren Urbano) and hopefully will be added to Transport soon. :-)