-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: link library for dot #903
base: master
Are you sure you want to change the base?
Conversation
|
||
import org.schemaspy.model.Table; | ||
|
||
public class AddTableNodeLinkFactory implements TableNodeLinkFactory{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a better name
@Override | ||
public NodeLink nodeLink(Table table) { | ||
if (table.isRemote()) { | ||
return new RemoteFromBase(table, new HtmlWithEncodedName(table)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HtmlWithEncodedName should probably be it's own Factory
|
||
@Override | ||
public String asString() { | ||
return " URL=\"" +nodeLink.asString() + "\"" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL maybe a separate factory
Could be simplified by returning string instead of NodeLink. @jesperolsson-se if you have the time could you help me with this. |
Usage commit: npetzall@8167703 Just to show some of the enabling. |
If #900 is fruitful, The awkward
Can be removed. |
Link library to remove createPath() from DotNode
schemaspy/src/main/java/org/schemaspy/output/dot/schemaspy/DotNode.java
Lines 78 to 87 in 5d2b830
But also remove isOneOfMultipleSchemas()
schemaspy/src/main/java/org/schemaspy/output/dot/schemaspy/DotNode.java
Lines 132 to 135 in 5d2b830
Enabling us to remove useRelativeLinks() from
Enabling us to remove isOneOfMultipleSchemas() from Config/DotConfig/HtmlConfig since it set in runtime and not config from cli. There are more places that needs changing.