Add codespell: config + workflow (to catch new typos) + fix a number of typos using codespell #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e.py
=== Do not change lines below ===
{
"chain": [],
"cmd": "git-sedi supress suppress",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
This was referenced Mar 1, 2024
MatthiasWiesmann
requested changes
Mar 6, 2024
There was a problem hiding this comment.
I don't think this fix is correct:
- reoccurrence = a further or repeated occurrence.
- recurrence = the fact of occurring again.
There was a problem hiding this comment.
thanks for spotting!
Filed
- Remove reoccurrence from the dictionary.txt -- LGTM and popular word codespell-project/codespell#3378
to address "upstream".
Redid fixing, force-pushed.
yarikoptic
added a commit
to yarikoptic/codespell
that referenced
this pull request
Mar 6, 2024
Originally spotted by @MatthiasWiesmann in review of - schemaorg/schemaorg#3474 And indeed, "reoccurrence" has different meaning from "recurrence" and also formally listed in dictionaries, e.g. - https://www.oed.com/dictionary/reoccurrence_n?tl=true - https://en.wiktionary.org/wiki/reoccurrence In search trends https://trends.google.com/trends/explore?geo=US&q=reoccurrence,recurrence&hl=en it is only 3 to 79 so ~25 times less "popular" than "recurrence". Overall -- LGTM, used widely enough, and thus IMHO should not be listed as a typo.
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w -i 3 -C 2",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
LGTM, fix proposed upstream - codespell-project/codespell#3378
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
d662d71
to
69be575
Compare
DimitriPapadopoulos
pushed a commit
to codespell-project/codespell
that referenced
this pull request
Mar 6, 2024
Originally spotted by @MatthiasWiesmann in review of - schemaorg/schemaorg#3474 And indeed, "reoccurrence" has different meaning from "recurrence" and also formally listed in dictionaries, e.g. - https://www.oed.com/dictionary/reoccurrence_n?tl=true - https://en.wiktionary.org/wiki/reoccurrence In search trends https://trends.google.com/trends/explore?geo=US&q=reoccurrence,recurrence&hl=en it is only 3 to 79 so ~25 times less "popular" than "recurrence". Overall -- LGTM, used widely enough, and thus IMHO should not be listed as a typo.
MatthiasWiesmann
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially encountered typos in another representation of past version of linkml elsewhere, decided to fix them "in the root" ;) more on codespell: https://github.com/codespell-project/codespell . Resulted in fixing some code including 1 interface but IMHO was ok.