Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed all inheritance warnings in schema.org #3356

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed all inheritance warnings in schema.org #3356

wants to merge 2 commits into from

Conversation

MatthiasWiesmann
Copy link
Contributor

Fixed all inheritance warnings in the repository, activated the test.

  • All domain or range declaration where the target inherits from another target have been removed, or if this would have resulted in an empty declaration, replaced with the common parent.
  • All the related tests are not activated (not expected to fail). In case of failure, each failure case is its own subtest with reporting.
  • Removed some globals that are not needed anymore.

@MatthiasWiesmann
Fixed property and range to only have the root type.
0ebc250 
Updated unit-test to not expect these types of failures.
Improved the error reporting in the unit test to handle each error as a sub-test.
@MatthiasWiesmann
Removed globals.
0aa1596
@RichardWallis
Copy link
Contributor

@danbri should review this - replacing specific domain/range declarations with a more generic one may have some merit, it may also diverge from the guiding intent of the the author of the definition and make things more confusing for implementers.

@MatthiasWiesmann
Copy link
Contributor Author

Note that these replacements have no actual effect, as the the more generic type takes precedence anyway when the documentation is generated. So whatever intent was present is not surfaced anyways.

@RichardWallis
Copy link
Contributor

I agree that there is no ontological effect, however properties are sometimes referenced in a subtype description, in addition to the inherited generic type, specifically to hint to implementers that it is an appropriate property to use for that subtype.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

This pull request is being nudged due to inactivity.

@github-actions github-actions bot added the no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbri danbri Awaiting requested review from danbri

Assignees
No one assigned
Labels
no-pr-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MatthiasWiesmann @RichardWallis