Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DonateAction a TransferAction instead of a TradeAction #3338

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Jun 18, 2023

  1. Update schema.ttl

    DonateAction is explicitly "without compensation", so I propose to make it a subclass of TransferAction instead.
    
    All the other TradeActions involve a swap of items or an intention of each party both giving something and receiving something in return. (In fact, in broader contexts, the concept of trade is intentionally separated from gifts and donations -- there's even a saying that "trade is the origin of most problems". :-)
    
    There are 3 properties of TradeAction that would be lost: price, priceCurrency, and priceSpecification. To include price, one might make the `object` property be a MonetaryValue or TypeAndQuantityNode -- and if there's already an `object` then that might be turned into an array. (I posit that it does not need priceSpecification.)
    trentlarson committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    b45ffb8 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. Configuration menu
    Copy the full SHA
    5c51d03 View commit details
    Browse the repository at this point in the history