Allow Text for duration-properties, fixes #3021
#2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As examples in `Audiobook` state, the `duration`-property can be a
`Text` and does not have to be a `Duration`-class.
```
{
"@context": "https://schema.org/",
"type": "Audiobook",
"@id": "https://archive.org/id",
"author": "Lewis Carroll",
"duration": "PT2H31M21S"
}
```
jaylinski
changed the title
Text for the duration-propertiesText for duration-properties
jaylinski
changed the title
Text for duration-propertiesText for duration-properties, fixes #3021
|
This pull request is being nudged due to inactivity. |
github-actions
bot
added
the
no-pr-activity
|
This PR is still relevant. I'm just not sure how I can get anyone from the schemaorg-team involved... |
|
yeah, this PR should not be moved to inactive and thank you for standing on top of this issue and allowing it to follow through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As examples in
Audiobookstate, theduration-property can be aTextand does not have to be aDuration-class:https://schema.org/Audiobook
Maybe I'm missing something and the schema already allows a
Text-value, but the main reason I'm opening this PR is issue spatie/schema-org#172.Thanks for taking your time to review this PR.
Fixes #3021.